fix: canonicalize arithmetic generics in array lengths #6494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
changed the title
…zation * master: chore: move tests for arithmetic generics closer to the code (#6497)
|
@asterite Can you take a look at this? This is blocking a Noir sync atm. |
jfecher
requested changes
Nov 11, 2024
Comment on lines
+114
to
+117
| Type::Array(length, element) => Type::Array( | ||
| Box::new(length.canonicalize_helper(found_checked_cast, run_simplifications)), | ||
| element, | ||
| ), |
There was a problem hiding this comment.
I can see what this does but can you elaborate why it was added? The intent of canonicalize was to only work on numeric types. If we start trying to find and canonicalize types recursively like this we're missing a bunch of cases, e.g. numerics in struct generics, handling type variables, etc.
There was a problem hiding this comment.
I can see this is blocking a sync but I still want to ensure its the right solution before just merging it
|
Yeah, thinking this probably isn't the way to go on second thoughts. The unit test is almost certainly not reflecting what's in the sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #6495
Summary*
We're getting build failures in AztecProtocol/aztec-packages#9769 due to not being able to solve
[Field; (N - 1) + 1]to[Field; N]. This PR adds a unit test showing a case which we should be able to simplify but aren't.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.