Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Elaborate generated items as we go #6234

Closed
wants to merge 1 commit into from

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Oct 7, 2024

Description

Problem*

Resolves #6143

Summary*

Elaborate items generated at comptime as they're generated instead of all at once later on. This is a breaking change since any code e.g. outputting functions from attributes which rely on types that are outputted later will now error and the ordering will need to be changes.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher added the run-external-checks Trigger CI job to run tests on external repos label Oct 7, 2024
@jfecher jfecher requested a review from a team October 7, 2024 14:44
@jfecher
Copy link
Contributor Author

jfecher commented Oct 7, 2024

 error: No matching impl found for `MyOtherOtherStruct<B>: Default`
   ┌─ execution_success/derive/src/main.nr:26:3
   │
26 │ #[derive(Eq, Default, Hash, Ord)]
   │   ------------------------------ No impl for `MyOtherOtherStruct<B>: Default`
   │

This may be a no-go as it breaks derive when the wrapper type is derived before all the field types are

@jfecher jfecher marked this pull request as draft October 7, 2024 14:52
@jfecher jfecher closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-external-checks Trigger CI job to run tests on external repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

derived traits are not found by get_trait_impl
1 participant