chore: sanitize url's to only allow github #5776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to Brillig bytecode sizes
There are no changes in circuit sizes |
TomAFrench
approved these changes
Aug 21, 2024
|
Actually can you add a quick test with a malicious URL? |
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 22, 2024
…r-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 23, 2024
…ents (noir-lang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 23, 2024
…ang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 24, 2024
…5802) chore: Add comptime docs (noir-lang/noir#5800) fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (noir-lang/noir#5788) fix(acir_gen): Nested dynamic array initialization (noir-lang/noir#5810) fix: honor function visibility in LSP completion (noir-lang/noir#5809) feat: LSP completion now works better in the middle of idents (noir-lang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 24, 2024
chore: Add comptime docs (noir-lang/noir#5800) fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (noir-lang/noir#5788) fix(acir_gen): Nested dynamic array initialization (noir-lang/noir#5810) fix: honor function visibility in LSP completion (noir-lang/noir#5809) feat: LSP completion now works better in the middle of idents (noir-lang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 25, 2024
…5802) chore: Add comptime docs (noir-lang/noir#5800) fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (noir-lang/noir#5788) fix(acir_gen): Nested dynamic array initialization (noir-lang/noir#5810) fix: honor function visibility in LSP completion (noir-lang/noir#5809) feat: LSP completion now works better in the middle of idents (noir-lang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 25, 2024
chore: Add comptime docs (noir-lang/noir#5800) fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (noir-lang/noir#5788) fix(acir_gen): Nested dynamic array initialization (noir-lang/noir#5810) fix: honor function visibility in LSP completion (noir-lang/noir#5809) feat: LSP completion now works better in the middle of idents (noir-lang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 26, 2024
…5802) chore: Add comptime docs (noir-lang/noir#5800) fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (noir-lang/noir#5788) fix(acir_gen): Nested dynamic array initialization (noir-lang/noir#5810) fix: honor function visibility in LSP completion (noir-lang/noir#5809) feat: LSP completion now works better in the middle of idents (noir-lang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 26, 2024
chore: Add comptime docs (noir-lang/noir#5800) fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (noir-lang/noir#5788) fix(acir_gen): Nested dynamic array initialization (noir-lang/noir#5810) fix: honor function visibility in LSP completion (noir-lang/noir#5809) feat: LSP completion now works better in the middle of idents (noir-lang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 27, 2024
feat: Improve "type annotations needed" errors (noir-lang/noir#5830) chore: enum dummy ID for `FuncId` in monomorphizer and docstring fixes (noir-lang/noir#5421) chore: delete wip fuzzing files that got accidentally added (noir-lang/noir#5829) chore: test ACVM `BigInt` (noir-lang/noir#5559) fix(docs): Fix file paths for metaprogramming docs (noir-lang/noir#5826) fix: bit shifting type checking (noir-lang/noir#5824) feat: add Expr::as_method_call (noir-lang/noir#5822) chore: Fix docs typo (noir-lang/noir#5821) feat: add `UnresolvedType::is_field` and `Expr::as_assign` (noir-lang/noir#5804) chore: Add docs for each comptime method (noir-lang/noir#5802) chore: Add comptime docs (noir-lang/noir#5800) fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (noir-lang/noir#5788) fix(acir_gen): Nested dynamic array initialization (noir-lang/noir#5810) fix: honor function visibility in LSP completion (noir-lang/noir#5809) feat: LSP completion now works better in the middle of idents (noir-lang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 27, 2024
feat: Improve "type annotations needed" errors (noir-lang/noir#5830) chore: enum dummy ID for `FuncId` in monomorphizer and docstring fixes (noir-lang/noir#5421) chore: delete wip fuzzing files that got accidentally added (noir-lang/noir#5829) chore: test ACVM `BigInt` (noir-lang/noir#5559) fix(docs): Fix file paths for metaprogramming docs (noir-lang/noir#5826) fix: bit shifting type checking (noir-lang/noir#5824) feat: add Expr::as_method_call (noir-lang/noir#5822) chore: Fix docs typo (noir-lang/noir#5821) feat: add `UnresolvedType::is_field` and `Expr::as_assign` (noir-lang/noir#5804) chore: Add docs for each comptime method (noir-lang/noir#5802) chore: Add comptime docs (noir-lang/noir#5800) fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (noir-lang/noir#5788) fix(acir_gen): Nested dynamic array initialization (noir-lang/noir#5810) fix: honor function visibility in LSP completion (noir-lang/noir#5809) feat: LSP completion now works better in the middle of idents (noir-lang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)
sirasistant
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 27, 2024
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: crypto blackbox tests (noir-lang/noir#5614) feat: Improve "type annotations needed" errors (noir-lang/noir#5830) chore: enum dummy ID for `FuncId` in monomorphizer and docstring fixes (noir-lang/noir#5421) chore: delete wip fuzzing files that got accidentally added (noir-lang/noir#5829) chore: test ACVM `BigInt` (noir-lang/noir#5559) fix(docs): Fix file paths for metaprogramming docs (noir-lang/noir#5826) fix: bit shifting type checking (noir-lang/noir#5824) feat: add Expr::as_method_call (noir-lang/noir#5822) chore: Fix docs typo (noir-lang/noir#5821) feat: add `UnresolvedType::is_field` and `Expr::as_assign` (noir-lang/noir#5804) chore: Add docs for each comptime method (noir-lang/noir#5802) chore: Add comptime docs (noir-lang/noir#5800) fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (noir-lang/noir#5788) fix(acir_gen): Nested dynamic array initialization (noir-lang/noir#5810) fix: honor function visibility in LSP completion (noir-lang/noir#5809) feat: LSP completion now works better in the middle of idents (noir-lang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768) END_COMMIT_OVERRIDE --------- Co-authored-by: sirasistant <[email protected]> Co-authored-by: Maxim Vezenov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #5737
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.