chore: test remaining crypto blackbox functions #5702
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eidon2 permutation parameters public
…ash function solver setup, refactor solvers into shared solver, wip injectivity tests
…elper fn and tests, add _zeros smoke tests
michaeljklein
changed the title
5 tasks
…-lang/noir into michaeljklein/crypto-blackbox-tests
…tch poseidon2_permutation_invalid_size_fails
…, some tests now passing
Changes to Brillig bytecode sizes
There are no changes in circuit sizes |
|
What's the status on this PR? |
|
@TomAFrench It's on hold as lower-priority. Next step is splitting it into existing unit tests and remaining elliptic curve tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change base to master after chore: crypto blackbox tests #5614 is merged
Test field <-> value conversion used for multi-scalar-mul and embedded curve add
Test multi-scalar-mul
Test embedded curve add
Test range check/constraint
Problem*
Resolves
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.