fix: Fix evaluation of globals from other crates #5658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vezenovm
approved these changes
Aug 1, 2024
# Description ## Problem\* Resolves #5628 ## Summary\* The original error in the issue has since been fixed, but there have been more after it. #5658 fixes the last issue and with it, derive can be added to the stdlib without errors. I've edited the `derive` test to show this. ## Additional Context After this, I'm making another separate PR to add some derive functions for common traits like Eq and Default. ## Documentation\* Check one: - [ ] No documentation needed. - [ ] Documentation included in this PR. - [x] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
We stored
comptime_scopesin the Elaborator, but elaborators are created one per each crate. So any globals from other crates would be invisible to each next crate, or their value would be reset. I've movedcomptime_scopesto the NodeInterner to fix this.Additional Context
With this,
derivenow works in the stdlib. I've decided to split adding that into a separate PR though.Documentation*
Check one:
PR Checklist*
cargo fmton default settings.