Code

feat!: remove dep:: prefix#4946

Code

Merged

TomAFrench merged 37 commits intomasternoir-lang/noir:masterfrom michaeljklein/combine-dep-cratenoir-lang/noir:michaeljklein/combine-dep-crateCopy head branch name to clipboardJun 17, 2024

+375-369

Commits

Commits on Apr 30, 2024

• use PathKind::Plain over Dep, remove PathKind::Dep, resolve both possibilities when PathKind::Plain encountered, add test to ensure case never encountered in nargo_fmt, update path parsers, update …

  Show description for 167e153
  michaeljklein

  committed
  167e153

  Copy full SHA for 167e153

• removing from aztec_macros, expected-to-be failing test_programs, etc

  michaeljklein

  committed
  425116f

  Copy full SHA for 425116f

• only resolve path externally when unresolved internally, i.e. not when other errors occur, make backwards compatible

  michaeljklein

  committed
  ec7eb40

  Copy full SHA for ec7eb40

• add PathKind::Dep back in 1) to ease distinguishing deprecated case, 2) so that it can be used for the '::' prefix later, add deprecation warning

  michaeljklein

  committed
  91e003e

  Copy full SHA for 91e003e

• cargo fmt/clippy

  michaeljklein

  committed
  22ec8c7

  Copy full SHA for 22ec8c7

• Merge branch 'master' into michaeljklein/combine-dep-crate

  michaeljklein

  authored
  7ad8d05

  Copy full SHA for 7ad8d05

• fix tests failing from deprecation warning

  michaeljklein

  committed
  552b29b

  Copy full SHA for 552b29b

Commits on May 1, 2024

• Update compiler/noirc_frontend/src/parser/errors.rs

  Show description for c8ba6f5
  

  michaeljklein

  and

  TomAFrench

  authored
  c8ba6f5

  Copy full SHA for c8ba6f5

• Update compiler/noirc_frontend/src/hir/resolution/import.rs

  Show description for 51bbb0e
  

  michaeljklein

  and

  TomAFrench

  authored
  51bbb0e

  Copy full SHA for 51bbb0e

Commits on May 8, 2024

• Merge branch 'master' into michaeljklein/combine-dep-crate

  michaeljklein

  committed
  3493069

  Copy full SHA for 3493069

Commits on May 9, 2024

• wip responding to review comments, distinguish deprecated path kind from '::path', only resolve plain path as external when the first segment isn't found, rename DepPathPrefixDeprecated -> LitDepPa…

  Show description for 0da34b2
  michaeljklein

  committed
  0da34b2

  Copy full SHA for 0da34b2

• remove LitDep and associated warning, revert parser

  michaeljklein

  committed
  a00b775

  Copy full SHA for a00b775

• Merge branch 'master' into michaeljklein/combine-dep-crate

  michaeljklein

  authored
  2c6b20b

  Copy full SHA for 2c6b20b

• update previous-approach '::path' tests, simplify dep/mod overlap test

  michaeljklein

  committed
  97bfe72

  Copy full SHA for 97bfe72

Commits on May 10, 2024

• Merge branch 'master' into michaeljklein/combine-dep-crate

  michaeljklein

  authored
  b47f8b7

  Copy full SHA for b47f8b7

• add test for external vs local import without 'dep::'

  michaeljklein

  committed
  8a4d138

  Copy full SHA for 8a4d138

• convert overlapping_dep_and_mod to a compile failure by moving expected overlap from dep::foo::bar != foo::bar to foo::bar/foo::baz (overlapping module name)

  michaeljklein

  committed
  085d1f6

  Copy full SHA for 085d1f6

• add 'overlapping_dep_and_mod*' tests to excluded_dirs in formatting test (as they're a type of workspace test)

  michaeljklein

  committed
  11f6235

  Copy full SHA for 11f6235

• Merge branch 'master' into michaeljklein/combine-dep-crate

  michaeljklein

  authored
  d374c04

  Copy full SHA for d374c04

• nargo fmt

  michaeljklein

  committed
  268490f

  Copy full SHA for 268490f

Commits on May 14, 2024

• Merge branch 'master' into michaeljklein/combine-dep-crate

  michaeljklein

  authored
  0842de8

  Copy full SHA for 0842de8

Commits on Jun 10, 2024

• Merge branch 'master' into michaeljklein/combine-dep-crate

  michaeljklein

  committed
  a4437f5

  Copy full SHA for a4437f5

• nargo fmt

  michaeljklein

  committed
  fb82de4

  Copy full SHA for fb82de4

Commits on Jun 11, 2024

• Merge branch 'master' into michaeljklein/combine-dep-crate

  michaeljklein

  authored
  3d36751

  Copy full SHA for 3d36751

Commits on Jun 14, 2024

• Merge branch 'master' into michaeljklein/combine-dep-crate

  michaeljklein

  authored
  cea5f46

  Copy full SHA for cea5f46

Commits on Jun 17, 2024

• Merge branch 'master' into michaeljklein/combine-dep-crate

  Show description for fd1b873
  TomAFrench

  committed
  fd1b873

  Copy full SHA for fd1b873

• chore: fmt

  TomAFrench

  committed
  7b3eb42

  Copy full SHA for 7b3eb42

• chore: update new paths

  TomAFrench

  committed
  9111c2a

  Copy full SHA for 9111c2a

• chore: fix naming of new test

  TomAFrench

  committed
  0a876b3

  Copy full SHA for 0a876b3

• chore: restrict parallelism in rebuild.sh

  TomAFrench

  committed
  407b22a

  Copy full SHA for 407b22a

• chore: remove useless use std statements

  TomAFrench

  committed
  ec2b819

  Copy full SHA for ec2b819

• chore: clean up straggler

  TomAFrench

  committed
  c51cdd6

  Copy full SHA for c51cdd6

• chore: revert change to formatter test

  TomAFrench

  committed
  74526c4

  Copy full SHA for 74526c4

• Update compiler/noirc_frontend/src/parser/errors.rs

  TomAFrench

  authored
  a53fb5c

  Copy full SHA for a53fb5c

• Update docs/docs/noir/concepts/data_types/slices.mdx

  TomAFrench

  authored
  ac9cdbc

  Copy full SHA for ac9cdbc

• chore: revert changes to formatter

  TomAFrench

  committed
  8816095

  Copy full SHA for 8816095

• Merge branch 'master' into michaeljklein/combine-dep-crate

  Show description for 787e020
  TomAFrench

  committed
  787e020

  Copy full SHA for 787e020