Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add option to specify output directory on codegen cmd and use generic names #4479

Conversation

nicolasgarcia214
Copy link
Contributor

Description

This PR adds the option to specify an output directory for the generated contracts of the codegen-verifier command. Also changes the fixed name plonk_vk.sol to <PACKAGE_NAME>_verifier.sol.

Problem

Closes #4476 and #4477

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Thank you for your contribution to the Noir language.

Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch.

Thanks for your understanding.

@kevaundray kevaundray changed the title Add option to specify output directory on codegen cmd and use generic names feat!: Add option to specify output directory on codegen cmd and use generic names Mar 5, 2024
@TomAFrench
Copy link
Member

Hey, I'm closing this PR as we've removed the codegen-verifier feature and instead this should be done through barretenberg directly.

@TomAFrench TomAFrench closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to specify output directory path when running nargo codegen-verifier
2 participants