Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove noir_wasm dependency on noirc_abi_wasm #4315

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

noir_wasms dependency on noirc_abi_wasm is preventing us from building it in parallel. It only relies on types so I've moved those to noir_js_types and both of those packages pull these types in.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench added this pull request to the merge queue Feb 9, 2024
Merged via the queue into master with commit 87bb6e2 Feb 9, 2024
34 checks passed
@TomAFrench TomAFrench deleted the tf/parallelise-more-builds branch February 9, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants