Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add better type safety in noir_js_backend_barretenberg #4103

Merged
merged 1 commit into from
Jan 22, 2024
Merged

chore: add better type safety in noir_js_backend_barretenberg #4103

merged 1 commit into from
Jan 22, 2024

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This PR stops api from being the any type so we get type safety when calling methods on it.

This doesn't affect the lazy loading of bb.js as we're only importing types which get stripped out by typescript.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray added this pull request to the merge queue Jan 22, 2024
Merged via the queue into master with commit ae5c630 Jan 22, 2024
31 checks passed
@kevaundray kevaundray deleted the tf/better-type-safety-in-barretenberg-backend branch January 22, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @kevaundray