chore: rename barretenberg_blackbox_solver
to bn254_blackbox_solver
#3874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR renames
barretenberg_blackbox_solver
tobn254_blackbox_solver
and marks it as not deprecated.This signifies that these blackbox solvers should work against all backends targetting the bn254 curve and not just barretenberg. That we're using barretenberg to solve them is then just an implementation detail.
We've decided to retain the
BlackBoxFunctionSolver
trait to allow these solvers to be swapped out based on theFieldElement
implementation and so the newBn254BlackBoxSolver
is not deprecated.Additional Context
Now that this solver is tied to a curve rather than a particular backend, it's now proper to integrate it into the compiler such that we can solve black box functions such as that which caused #3865
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.