Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename barretenberg_blackbox_solver to bn254_blackbox_solver #3874

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This PR renames barretenberg_blackbox_solver to bn254_blackbox_solver and marks it as not deprecated.

This signifies that these blackbox solvers should work against all backends targetting the bn254 curve and not just barretenberg. That we're using barretenberg to solve them is then just an implementation detail.

We've decided to retain the BlackBoxFunctionSolver trait to allow these solvers to be swapped out based on the FieldElement implementation and so the new Bn254BlackBoxSolver is not deprecated.

Additional Context

Now that this solver is tied to a curve rather than a particular backend, it's now proper to integrate it into the compiler such that we can solve black box functions such as that which caused #3865

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray added this pull request to the merge queue Dec 19, 2023
Merged via the queue into master with commit 7a4e845 Dec 19, 2023
30 checks passed
@kevaundray kevaundray deleted the tf/bn254-blackbox-solver branch December 19, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants