Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: Change Language -> ExpressionWidth and put ExpressionWidth into Circuit #3827

Closed
wants to merge 13 commits into from
Closed

chore!: Change Language -> ExpressionWidth and put ExpressionWidth into Circuit #3827

wants to merge 13 commits into from

Conversation

kevaundray
Copy link
Contributor

Description

This changes the naming of NpLanguage to ExpressionWidth and then puts it into Circuit, so that its always apparent when a circuit has been reduced

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

kevaundray and others added 13 commits December 14, 2023 12:54
@kevaundray
remove partial backend feature
7f126e8
@kevaundray
fix
455c824
@kevaundray @TomAFrench
Update tooling/nargo/src/ops/compile.rs
a110b2e 
Co-authored-by: Tom French <[email protected]>
@kevaundray @TomAFrench
Update tooling/nargo/src/ops/compile.rs
b697709 
Co-authored-by: Tom French <[email protected]>
@kevaundray @TomAFrench
Update tooling/backend_interface/src/proof_system.rs
bf75aa8 
Co-authored-by: Tom French <[email protected]>
@kevaundray @TomAFrench
Update tooling/backend_interface/src/proof_system.rs
55c0ed8 
Co-authored-by: Tom French <[email protected]>
@kevaundray
fix
8766992
@kevaundray
Merge remote-tracking branch 'origin/master' into kw/remove-partial-b…
d9f5bc7 
…ackend-code
@kevaundray
merge fix
88584eb
@kevaundray
remove backend field from artifacts
67bd5f8
@kevaundray
Multi
c8bf46b 
- rename NpLanguage -> ExpressionWidth
- put ExpressionWidth into Circuit struct
@kevaundray
rename program_width to expression_width
ec4dece
@kevaundray
add small doc comment
b3a9672
@kevaundray kevaundray mentioned this pull request Dec 16, 2023
Merged
5 tasks
Base automatically changed from kw/remove-backend-field to master December 16, 2023 21:09
@kevaundray
Copy link
Contributor Author

The remaining change we want to pull out of this is putting expression_width into Circuit

@TomAFrench TomAFrench linked an issue Jan 11, 2024 that may be closed by this pull request
Put ExpressionWidth into the circuit definition #4012
Closed
@TomAFrench
Copy link
Member

Going to close this as a lot of the changes are already included and it hasn't kept up with conflicts

@TomAFrench TomAFrench closed this Jan 22, 2024
@TomAFrench TomAFrench deleted the kw/add-np-language-into-circuit branch November 20, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Put ExpressionWidth into the circuit definition
2 participants
@kevaundray @TomAFrench