-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: conservatively use log::info instead of println for some expressions #3766
Conversation
I'll open an issue to standardize the categories of logging we have -- some logging like printing out ACIR should be done using println, though for things like "Constraint system successfully built" its a bit trickier because its informational (we don't want it info level logs to be printed out by default), but we also want it to be printed out to tell the user that their program was built successfully |
There might be something inherently wrong with my assumption in that we want things like "constraint system built successfully" to always be printed out -- I vaguely remember an issue where someone said that it was not easy to see what had happened. Another solution is to just create another logging level "feedback" and put these under that category |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this. I'm a little concerned about hiding some of the warnings related to interacting with backends by default but we can see how that goes to see if we get a resurgence of user questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm alright with this for now as well. We can re-evaluate it later if needed
Description
If you want to see info level logs, you can do
NOIR_LOG=info nargo compile
by default if that environment variable is not set, then it will only print out error level logsProblem*
Resolves
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.