Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add mold to github action #3544

Closed
wants to merge 3 commits into from
Closed

chore: add mold to github action #3544

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 23, 2023

Description

Problem

Resolves #3538

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@ghost ghost changed the base branch from tf/unflatten-backend-inputs to master November 23, 2023 09:14
@kevaundray
Copy link
Contributor

Was there any performance difference in adding mold?

@ghost
Copy link
Author

ghost commented Nov 23, 2023

I don't see any difference, except for a slight noise, which is probably within the margin of error.

@jfecher
Copy link
Contributor

jfecher commented Nov 27, 2023

I use mold locally and it improves performance for me. I have it linked to ld

@TomAFrench
Copy link
Member

What's the status of this PR?

@ghost ghost closed this Dec 20, 2023
@ghost
Copy link
Author

ghost commented Dec 20, 2023

It seems I couldn't achieve the expected results, perhaps someone else might succeed.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate adding the mold linker
3 participants