Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor FileManager initialization and introduce with_reader constructor #3434

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 6, 2023

Description

FileManager Refactoring: The FileManager::new function was refactored. Previously, it required a Box as a parameter for file reading. Now, it has been split into two methods:

  • FileManager::new, which no longer takes a Box and uses std::fs::read_to_string by default.
  • FileManager::with_reader, which takes a Box to allow custom file reading.

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray
Copy link
Contributor

This is superceded in favour of #3760

@kevaundray kevaundray closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant