Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add warning when using verify_proof #3429

Merged
merged 3 commits into from
Nov 6, 2023
Merged

chore: add warning when using verify_proof #3429

merged 3 commits into from
Nov 6, 2023

Conversation

guipublic
Copy link
Contributor

Description

Problem*

Resolves #3158

Summary*

Display a warning during compilation of a program which uses proof recursion.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@guipublic guipublic changed the title add warning when using verify_proof chore: add warning when using verify_proof Nov 3, 2023
vezenovm
vezenovm reviewed Nov 3, 2023
View reviewed changes
Copy link
Contributor

@vezenovm vezenovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should consider renaming verify_proof to aggregate_proof or something in a later PR

compiler/noirc_evaluator/src/errors.rs Outdated Show resolved Hide resolved
@guipublic guipublic added this pull request to the merge queue Nov 6, 2023
Merged via the queue into master with commit 874b2bf Nov 6, 2023
32 checks passed
@guipublic guipublic deleted the gd/issue_3158 branch November 6, 2023 14:58
TomAFrench pushed a commit that referenced this pull request Nov 14, 2023
@guipublic @TomAFrench
chore: add warning when using verify_proof (#3429)
3931af6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vezenovm vezenovm vezenovm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a message during execution to tell the user that the recursion opcode is not being executed
2 participants
@guipublic @vezenovm