Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix rebuild acir artifacts workflow #3422

Merged
merged 7 commits into from
Nov 3, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

We currently don't run the auto-pr-rebuild-script job on master for reason connected to how github actions handles conditions. This PR moves this condition to only cover the artifact upload so I can debug it more easily.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested a review from kevaundray November 3, 2023 13:46
@kevaundray kevaundray enabled auto-merge November 3, 2023 13:51
@TomAFrench TomAFrench disabled auto-merge November 3, 2023 13:53
@TomAFrench TomAFrench enabled auto-merge November 3, 2023 13:53
@TomAFrench TomAFrench changed the title chore(ci): always rebuild acir artifacts for PR chore(ci): fix rebuild acir artifacts workflow Nov 3, 2023
@TomAFrench TomAFrench added this pull request to the merge queue Nov 3, 2023
Merged via the queue into master with commit 02973a6 Nov 3, 2023
33 checks passed
@TomAFrench TomAFrench deleted the tf/always-make-artifact-pr branch November 3, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants