Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): making release-please commit new version to the repo #3417

Merged
merged 11 commits into from
Nov 6, 2023

Conversation

signorecello
Copy link
Contributor

Description

This PR makes release-please also trigger a commit with the new docs version

Problem*

After the changes in the release-please to cut new versions, dumb me forgot to make it actually commit the files to the repo

@TomAFrench
Copy link
Member

This is going to absolutely murder my notifications with all the comments on each commit.

@signorecello
Copy link
Contributor Author

I mean it comments only when there are changes in the docs I think?

@signorecello
Copy link
Contributor Author

btw this is ready 👍

Copy link
Collaborator

@Savio-Sou Savio-Sou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging this in to help push v0.19.0 docs out.

Let's improve comment spam (if any) with follow up PRs.

@Savio-Sou Savio-Sou added this pull request to the merge queue Nov 6, 2023
@Savio-Sou Savio-Sou added CI documentation Improvements or additions to documentation labels Nov 6, 2023
Merged via the queue into master with commit c7da833 Nov 6, 2023
32 checks passed
@Savio-Sou Savio-Sou deleted the zpedro/release_commit_new_v branch November 6, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants