Code

chore: Re-open #3258 #3410

Code

Merged

TomAFrench merged 98 commits intomasternoir-lang/noir:masterfrom mv/fill-slices-passnoir-lang/noir:mv/fill-slices-passCopy head branch name to clipboardNov 3, 2023

+862-55

Commits

Commits on Sep 14, 2023

• enabled dynamic indices on nested arrays

  vezenovm

  committed
  c2f2f62

  Copy full SHA for c2f2f62

• remove debug

  vezenovm

  committed
  45b3787

  Copy full SHA for 45b3787

Commits on Sep 15, 2023

• working non-homogenous arr accesses for block params

  vezenovm

  committed
  7ccf8e9

  Copy full SHA for 7ccf8e9

Commits on Sep 19, 2023

• add array_set, broken, need to maintain structure from SSA for accurate index

  vezenovm

  committed
  d5d16d7

  Copy full SHA for d5d16d7

• merge conflcits w/ master

  vezenovm

  committed
  ec54e01

  Copy full SHA for ec54e01

• working non-homogenous arrays using internal type element size array, heavy cleanup still needed

  vezenovm

  committed
  e2eff9b

  Copy full SHA for e2eff9b

• cleanup lots of debug and move const index access into its own method

  vezenovm

  committed
  219c8f2

  Copy full SHA for 219c8f2

• updating array_get and array_set to reduce repeated code

  vezenovm

  committed
  3195325

  Copy full SHA for 3195325

• restrict dynamic indices for non-homogenous slices

  vezenovm

  committed
  8fb3bb1

  Copy full SHA for 8fb3bb1

• cleanup array_get_value

  vezenovm

  committed
  469c333

  Copy full SHA for 469c333

• add internal_memory_blocks map

  vezenovm

  committed
  0648142

  Copy full SHA for 0648142

Commits on Sep 20, 2023

• do not make separate bool for handle_constant_index

  vezenovm

  committed
  b99f0e2

  Copy full SHA for b99f0e2

• fetch dummy value with predicate index

  vezenovm

  committed
  5784170

  Copy full SHA for 5784170

• flatten the index once for both array_set and array_get, do not modify modify the predicate index for the non-dummy val

  vezenovm

  committed
  05f35c6

  Copy full SHA for 05f35c6

Commits on Sep 21, 2023

• remove first_elem param

  vezenovm

  committed
  f2dd702

  Copy full SHA for f2dd702

Commits on Sep 25, 2023

• initial slice changes with fetch flat size from SSA values, need to get element type size array correct

  vezenovm

  committed
  490f5af

  Copy full SHA for 490f5af

• merge master

  vezenovm

  committed
  0037867

  Copy full SHA for 0037867

Commits on Sep 28, 2023

• initial working nested dynamic slices

  vezenovm

  committed
  3636bc6

  Copy full SHA for 3636bc6

• cleanup and fmt

  vezenovm

  committed
  31e7bc2

  Copy full SHA for 31e7bc2

• cargo clippy and fmt

  vezenovm

  committed
  4354b76

  Copy full SHA for 4354b76

• merge conflicts w/ master

  vezenovm

  committed
  87e8314

  Copy full SHA for 87e8314

• remove boolean AcirType

  vezenovm

  committed
  658d234

  Copy full SHA for 658d234

• remove deaad code not in master

  vezenovm

  committed
  408ac2c

  Copy full SHA for 408ac2c

• better solution for fetching nested slice with multiple slice mergesr

  vezenovm

  committed
  22ce20c

  Copy full SHA for 22ce20c

• bring back assert in nested_array_dynamic

  vezenovm

  committed
  686640e

  Copy full SHA for 686640e

• add assert to nested_slice_dynamic test

  vezenovm

  committed
  626616b

  Copy full SHA for 626616b

• cleanup w/ copy_dynamic_array method

  vezenovm

  committed
  f60183c

  Copy full SHA for f60183c

Commits on Sep 29, 2023

• starting test for slices in struct fields

  vezenovm

  committed
  be5dc79

  Copy full SHA for be5dc79

Commits on Oct 2, 2023

• more initial debugging for adding slices to struct fields

  vezenovm

  committed
  a7fde3e

  Copy full SHA for a7fde3e

Commits on Oct 3, 2023

• basic slice struct fields working, but broken for struct fields of different lengths

  vezenovm

  committed
  d1c9192

  Copy full SHA for d1c9192

Commits on Oct 4, 2023

• got old nested array and slice working with new acir, basic array get and set working for slice fields, fix flattening

  vezenovm

  committed
  6ab1212

  Copy full SHA for 6ab1212

• merged w/ master, and working old nested arr/slice tests, array_set from flattening still broken

  vezenovm

  committed
  d5911b8

  Copy full SHA for d5911b8

Commits on Oct 5, 2023

• heavy debugging work to get flattening with slice of slices working

  vezenovm

  committed
  b9c6a0a

  Copy full SHA for b9c6a0a

• working slice field in a struct

  vezenovm

  committed
  11f7dc8

  Copy full SHA for 11f7dc8

• little test func for flattened slice size of res

  vezenovm

  committed
  7f4c822

  Copy full SHA for 7f4c822

Commits on Oct 9, 2023

• merge conflicts w/ master

  vezenovm

  committed
  d97b965

  Copy full SHA for d97b965

Commits on Oct 11, 2023

• Merge branch 'master' into mv/slice-struct-fields

  vezenovm

  committed
  20f61a5

  Copy full SHA for 20f61a5

Commits on Oct 16, 2023

• merge conflicts w/ master

  vezenovm

  committed
  37a0f0f

  Copy full SHA for 37a0f0f

Commits on Oct 17, 2023

• update slice struct fields to use map of slice sizes in ACIR gen

  vezenovm

  committed
  1e0bd3f

  Copy full SHA for 1e0bd3f

• clean up dbgs and old debug in acvm

  vezenovm

  committed
  3b08844

  Copy full SHA for 3b08844

• cleanup

  vezenovm

  committed
  9086383

  Copy full SHA for 9086383

• comments update

  vezenovm

  committed
  f1c707c

  Copy full SHA for f1c707c

• check if we have side effects enabeld when flattening index

  vezenovm

  committed
  9108769

  Copy full SHA for 9108769

• Merge branch 'master' into mv/slice-struct-fields

  vezenovm

  committed
  589185c

  Copy full SHA for 589185c

• cleanup

  vezenovm

  committed
  4209388

  Copy full SHA for 4209388

• add TODOs to value merger

  vezenovm

  committed
  2949302

  Copy full SHA for 2949302

Commits on Oct 23, 2023

• fill internal slices pass

  vezenovm

  committed
  ce13374

  Copy full SHA for ce13374

• cleanup

  vezenovm

  committed
  554b8a9

  Copy full SHA for 554b8a9

• cleanup

  vezenovm

  committed
  c2d7ce7

  Copy full SHA for c2d7ce7

• fix up acir gen to not use value ids with slice values

  vezenovm

  committed
  27e0835

  Copy full SHA for 27e0835

• Merge branch 'master' into mv/slice-struct-fields

  vezenovm

  committed
  1456af9

  Copy full SHA for 1456af9

• fix for terminator in fill internal slices path

  vezenovm

  committed
  77b394e

  Copy full SHA for 77b394e

• Update compiler/noirc_evaluator/src/ssa/opt/fill_internal_slices.rs

  TomAFrench

  authored
  3850cf1

  Copy full SHA for 3850cf1

Commits on Oct 25, 2023

• working nested array get/set w/ no regressions

  vezenovm

  committed
  db60a52

  Copy full SHA for db60a52

• Merge branch 'mv/fill-slices-pass' into mv/fill-slices-pass-dbg

  vezenovm

  committed
  8cc5993

  Copy full SHA for 8cc5993

Commits on Oct 26, 2023

• working basic slice intrinsics on nested slices

  vezenovm

  committed
  a8d0431

  Copy full SHA for a8d0431

• debugging changes for no regressions and changes to ACIR gen

  vezenovm

  committed
  f9b8544

  Copy full SHA for f9b8544

• remove gate regression to get slice push back working for nested slices

  vezenovm

  committed
  00a2f47

  Copy full SHA for 00a2f47

• PR comment on removing from slice

  vezenovm

  committed
  43f11e5

  Copy full SHA for 43f11e5

Commits on Oct 27, 2023

• improve fill internal slices pass

  vezenovm

  committed
  0d39a6b

  Copy full SHA for 0d39a6b

• cargo fmt

  vezenovm

  committed
  6beabc2

  Copy full SHA for 6beabc2

Commits on Oct 30, 2023

• included simple unit test to fill internal slices pass

  vezenovm

  committed
  42c0547

  Copy full SHA for 42c0547

• cleanup

  vezenovm

  committed
  5236691

  Copy full SHA for 5236691

• missed cargo fmt

  vezenovm

  committed
  c31906d

  Copy full SHA for c31906d

• spell check

  vezenovm

  committed
  72a8a2a

  Copy full SHA for 72a8a2a

• remove broken push back

  vezenovm

  committed
  f231731

  Copy full SHA for f231731

Commits on Oct 31, 2023

• Update compiler/noirc_evaluator/src/ssa/opt/fill_internal_slices.rs

  vezenovm

  authored
  3b664a4

  Copy full SHA for 3b664a4

• Merge branch 'master' into mv/slice-struct-fields

  Show description for e58dbba
  TomAFrench

  committed
  e58dbba

  Copy full SHA for e58dbba

• Merge branch 'mv/slice-struct-fields' into mv/fill-slices-pass

  Show description for 0036938
  TomAFrench

  committed
  0036938

  Copy full SHA for 0036938

• chore: nargo fmt

  TomAFrench

  committed
  b48fb85

  Copy full SHA for b48fb85

• Update compiler/noirc_evaluator/src/ssa/acir_gen/mod.rs

  Show description for f30062e
  

  vezenovm

  and

  TomAFrench

  authored
  f30062e

  Copy full SHA for f30062e

• Update compiler/noirc_evaluator/src/ssa/opt/fill_internal_slices.rs

  Show description for 4612c96
  

  vezenovm

  and

  jfecher

  authored
  4612c96

  Copy full SHA for 4612c96

• Update compiler/noirc_evaluator/src/ssa/opt/fill_internal_slices.rs

  Show description for b59f8ce
  

  vezenovm

  and

  TomAFrench

  authored
  b59f8ce

  Copy full SHA for b59f8ce

• Update compiler/noirc_evaluator/src/ssa/opt/fill_internal_slices.rs

  Show description for 711a3ff
  

  vezenovm

  and

  TomAFrench

  authored
  711a3ff

  Copy full SHA for 711a3ff

• flip order of test data for readability

  vezenovm

  committed
  2a84478

  Copy full SHA for 2a84478

• format

  vezenovm

  committed
  0bafe8d

  Copy full SHA for 0bafe8d

• reduce nesting in attach_slice_dummies

  vezenovm

  committed
  a4ef11b

  Copy full SHA for a4ef11b

• feat(slices): Fill slice internal dummy data initial pass (#3258)

  Show description for dd3baec
  

  3 peopleauthored
  dd3baec

  Copy full SHA for dd3baec

Commits on Nov 1, 2023

• simplify predicate logic when fetching flattened index

  vezenovm

  committed
  3b30290

  Copy full SHA for 3b30290

• Update compiler/noirc_evaluator/src/ssa/acir_gen/mod.rs

  Show description for 4926713
  

  vezenovm

  and

  TomAFrench

  authored
  4926713

  Copy full SHA for 4926713

• use ok_or_else on store value slice sizes

  vezenovm

  committed
  24bfae9

  Copy full SHA for 24bfae9

• reduce nesting from compute_slice_sizes in acir gen

  vezenovm

  committed
  a8dae7a

  Copy full SHA for a8dae7a

• Merge branch 'master' into mv/slice-struct-fields

  vezenovm

  authored
  d558647

  Copy full SHA for d558647

• Merge branch 'master' into mv/slice-struct-fields

  jfecher

  authored
  ed372cc

  Copy full SHA for ed372cc

Commits on Nov 2, 2023

• Merge branch 'master' into mv/slice-struct-fields

  vezenovm

  authored
  ff280cb

  Copy full SHA for ff280cb

• revert merge of 3258

  vezenovm

  committed
  402f421

  Copy full SHA for 402f421

• merge in mv/slice-struct-fields

  vezenovm

  committed
  7ce4b52

  Copy full SHA for 7ce4b52

• use slice not mutable vec for array_get_value

  vezenovm

  committed
  5286fd1

  Copy full SHA for 5286fd1

• comment out failing constraints fixed by fill internal slices pass

  vezenovm

  committed
  96805de

  Copy full SHA for 96805de

• Merge branch 'mv/slice-struct-fields' into mv/fill-slices-pass

  vezenovm

  committed
  284e762

  Copy full SHA for 284e762

Commits on Nov 3, 2023

• Update compiler/noirc_evaluator/src/ssa/acir_gen/mod.rs

  Show description for c7649d3
  

  vezenovm

  and

  TomAFrench

  authored
  c7649d3

  Copy full SHA for c7649d3

• wrap parent_array in Some

  vezenovm

  committed
  bf0aa94

  Copy full SHA for bf0aa94

• Update compiler/noirc_evaluator/src/ssa/acir_gen/mod.rs

  Show description for 2528f3d
  

  vezenovm

  and

  TomAFrench

  authored
  2528f3d

  Copy full SHA for 2528f3d

• add comments for slize sizes

  vezenovm

  committed
  38669e9

  Copy full SHA for 38669e9

• remove catch all for contains_slice_element

  vezenovm

  committed
  2b446a1

  Copy full SHA for 2b446a1

• Merge branch 'master' into mv/slice-struct-fields

  vezenovm

  authored
  33beadf

  Copy full SHA for 33beadf

• Merge branch 'mv/slice-struct-fields' into mv/fill-slices-pass

  vezenovm

  authored
  750f2ad

  Copy full SHA for 750f2ad

• merge conflicts after #3187 merged w/ master

  vezenovm

  committed
  1577442

  Copy full SHA for 1577442