Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add hash_to_field_native function #3339

Merged
merged 1 commit into from
Oct 30, 2023
Merged

chore: add hash_to_field_native function #3339

merged 1 commit into from
Oct 30, 2023

Conversation

kevaundray
Copy link
Contributor

Description

I think we can merge this into #3338

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray changed the title chore: add hash_to_field_native chore: add hash_to_field_native function Oct 29, 2023
@kevaundray kevaundray mentioned this pull request Oct 29, 2023
Merged
5 tasks
@github-actions
Copy link
Contributor

Changes to circuit sizes

Generated at commit: f897018860b60e35cd78279ca878b76117ad2dd6, compared to commit: 1637083229d43002796fee48f0cca91b071e5644

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
hash_to_field +132 ❌ +136.08% 0 ➖ 0.00%
Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
hash_to_field 229 (+132) +136.08% 21,444 (0) 0.00%

@kevaundray kevaundray marked this pull request as ready for review October 29, 2023 16:53
@kevaundray kevaundray mentioned this pull request Oct 29, 2023
Closed
@kevaundray kevaundray merged commit c92c4d4 into kw/start-deprecating-hash-to-field Oct 30, 2023
30 checks passed
@kevaundray kevaundray deleted the kw/replace-hash-to-field-with-noir-alternative branch October 30, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guipublic guipublic guipublic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevaundray @guipublic