Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add lambda formatter #3117

Closed
wants to merge 5 commits into from
Closed

chore: add lambda formatter #3117

wants to merge 5 commits into from

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Oct 11, 2023

Description

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jonybur jonybur changed the title chore: add lambda expression chore: add lambda formatter Oct 11, 2023
Comment on lines 2 to 4
let val = 1;
let add_50 = | val | val + 50;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a larger lambda to this test? One with a block with a few statements inside?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Jake means to have a function body which isn't a one-liner rather than adding another argument. We want to show that this formatter will properly handle large lambda functions.

@kevaundray kevaundray closed this Oct 27, 2023
@kevaundray kevaundray deleted the jb-lambda-expression branch October 27, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants