Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable yarn immutable #3063

Closed
wants to merge 2 commits into from
Closed

Conversation

kobyhallx
Copy link
Contributor

Description

When yarn install is run with env.CI=true it operates with YARN_ENABLE_IMMUTABLE_INSTALLS=true.
Disabling this in workflow will prevent failure.

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kobyhallx kobyhallx requested a review from TomAFrench October 10, 2023 08:46
@kobyhallx kobyhallx changed the title Kh-disable-yarn-immutable chore: disable yarn immutable Oct 10, 2023
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong way to address this as it's a symptom of an underlying problem. The issue is how yarn.lock managed to get out of sync.

@kobyhallx
Copy link
Contributor Author

This is the wrong way to address this as it's a symptom of an underlying problem. The issue is how yarn.lock managed to get out of sync.

yarn.lock will get out of synch regularly not sure we want to waste time on this? At least I think it's ok to do that for nightly

@TomAFrench
Copy link
Member

If yarn.lock is out of sync for nightly, it'll be out of sync for everything. Checking this is as simple as running a yarn install --immutable in another workflow.

@TomAFrench
Copy link
Member

Closing in favour of #3064

@TomAFrench TomAFrench closed this Oct 10, 2023
@TomAFrench TomAFrench deleted the kh-disable-yarn-immutable branch November 20, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants