Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add mocked backend binary to improve compile_success_empty tests #2554

Merged
merged 11 commits into from
Sep 4, 2023

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Sep 4, 2023

Description

Problem*

Mitigation for AztecProtocol/aztec-packages#1961
resolves #2555

Summary*

This PR adds a very simple mocked backend binary which just returns 0 on stdout for all calls. This allows us to remove usage of bb for the compile_success_empty tests which cuts down significantly on the amount of memory needed to run the test suite.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench
Copy link
Member Author

TomAFrench commented Sep 4, 2023

Seems like this causes a regression due to the amount of copying and extra calls to nargo. Looks like we need to implement #2555 before this is useful.

Looks like cache was also a factor

Base automatically changed from backend-ls-cmd to master September 4, 2023 18:10
@TomAFrench TomAFrench marked this pull request as ready for review September 4, 2023 18:14
* master:
  feat: add `nargo backend ls` and `nargo backend use` command to switch between backends (#2552)
@TomAFrench TomAFrench added this pull request to the merge queue Sep 4, 2023
Merged via the queue into master with commit 1bd7111 Sep 4, 2023
@TomAFrench TomAFrench deleted the mock-backend branch September 4, 2023 18:55
TomAFrench added a commit that referenced this pull request Sep 5, 2023
* master:
  chore: Replace hashers of hashmaps in dfg with fxhashes (#2490)
  chore: remove duplicate span from FunctionReturnType (#2546)
  feat: Add support for brillig call stacks in runtime errors (#2549)
  feat: add `noirc_abi_wasm` crate for ABI encoding in JS (#1945)
  chore: move CRS files into their own directory (#2558)
  chore: Cleanup `rebuild.sh` script (#2470)
  chore(ci): add mocked backend binary to improve `compile_success_empty` tests (#2554)
  chore: add noir-source-resolver (#2485)
  chore: fix double verify proof (#2556)
  feat: add `nargo backend ls` and `nargo backend use` command to switch between backends (#2552)
  chore(ci): bump checkout action to v4 (#2551)
  feat: Support for optional assertion messages (#2491)
  fix: allow usage of decimal string encoding for fields larger than a `i128` (#2547)
  feat(nargo): add hidden option to produce JSON output from `nargo info` (#2542)
  chore(stdlib)!: Rename `fixed_base_scalar_mul` to be more descriptive (#2488)
  chore: Document requirement for range opcode on `r_witness` in  `GeneratedAcir::euclidean_division` (#2437)
  chore!: ACVM 0.24 (#2504)
  fix(aztec_noir): generalise loop to not always inject a hasher instance (#2529)
  chore: create helper functions for writing programs and contracts to file (#2526)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting the desired backend through an environment variable
2 participants