chore: Remove Value::Array in favor of Instruction::MakeArray

[jfecher]

Description

Problem*

Resolves #1733

Summary*

This PR is an experiment to see if removing Value::Array simplifies the code at all. Since it is the only Value that may contain other ValueIds, removing it means we no longer have to specially handle and recur on Value::Array when working on ValueIds.

So far though, preliminary results of this PR are that there are no large gains made from removing it.

Documentation

• This PR requires documentation updates when merged.

  • I will submit a noir-lang/docs PR.
  • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[jfecher]

Closing this PR, I don't think it's a large code improvement

[jfecher]

Reopening this, after some second thought I think this may still be valuable.

[jfecher]

I'm unsure why this memory init is needed now. Did we need it before as well? Neither array is used dynamically.

[jfecher]

Still one last bug in brillig_nested_arrays:

error: Internal Consistency Evaluators Errors: 

                    This is likely a bug. Consider Opening an issue at https://github.com/noir-lang/noir/issues
  ┌─ std/lib.nr:1:1
  │
1 │ mod hash;
  │ - ICE: "Called AcirValue::into_var on an array"
  │

[jfecher]

Closing this PR, there are too many confilcts to update it. I think the idea of a MakeArray instruction is still a good one and we should revisit this eventually.