Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for optional assertion messages #2491

Merged
merged 44 commits into from
Sep 4, 2023
Merged
Changes from 2 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
387b541
feat: assertion messages for acir and brillig
sirasistant Aug 21, 2023
a0f1b8c
rewrite assert msg handling
sirasistant Aug 23, 2023
268d42c
refactor: improve error handling
sirasistant Aug 30, 2023
f4af108
style: error message
sirasistant Aug 30, 2023
622b82d
Merge branch 'master' into arv/assert_msgs
sirasistant Aug 31, 2023
1c4af96
refactor: improving parser
sirasistant Aug 31, 2023
2520f39
fix: assert_eq and comptime messages
sirasistant Aug 31, 2023
9ef7340
test: updated parser tests
sirasistant Aug 31, 2023
bc87640
acvm 0.24
kevaundray Aug 31, 2023
e4fcc39
add artifacts
kevaundray Aug 31, 2023
fb538ae
style: remove old todo
sirasistant Aug 31, 2023
0432010
test: reorder parser test for clarity
sirasistant Aug 31, 2023
8a8f347
Merge branch 'master' into arv/assert_msgs
sirasistant Aug 31, 2023
af96ce4
test: added assert msgs in e2e
sirasistant Aug 31, 2023
71b9664
Merge remote-tracking branch 'origin/master' into kw/acvm-0-24
kevaundray Aug 31, 2023
cc7a37f
missed file
kevaundray Aug 31, 2023
0b98ae3
change to branch
kevaundray Aug 31, 2023
ff135e8
update bytecode
kevaundray Aug 31, 2023
ac03515
change trait definitions
kevaundray Aug 31, 2023
b20fcac
rebuild script
kevaundray Aug 31, 2023
6b82986
fix trait call and remove dirs
kevaundray Aug 31, 2023
03dcd55
Merge remote-tracking branch 'origin/master' into kw/acvm-0-24
kevaundray Sep 1, 2023
48e9d1d
Merge remote-tracking branch 'origin/master' into kw/acvm-0-24
kevaundray Sep 1, 2023
83c487d
use nightly
kevaundray Sep 1, 2023
6a7ff1a
commit to rebuild
kevaundray Sep 1, 2023
2d39ed7
update 1_mul.bytecode
kevaundray Sep 1, 2023
145e735
Merge branch 'kw/acvm-0-24' into arv/assert_msgs
sirasistant Sep 1, 2023
7166321
Merge branch 'kw/acvm-0-24' into arv/assert_msgs
sirasistant Sep 1, 2023
b813e05
update to 2788
kevaundray Sep 1, 2023
4ecbd3c
refactor: use closure for resolving asserts
sirasistant Sep 1, 2023
2f82a75
Merge branch 'kw/acvm-0-24' into arv/assert_msgs
sirasistant Sep 1, 2023
223d09c
Update Cargo.toml
kevaundray Sep 1, 2023
d5fae75
Merge remote-tracking branch 'origin/master' into kw/acvm-0-24
kevaundray Sep 1, 2023
fc1172a
update cargo.lock
kevaundray Sep 1, 2023
d115fde
patch acvm traits which have disappeared with acvm-backend-barretenberg
kevaundray Sep 1, 2023
4a5e31b
use bb 0.5.0
kevaundray Sep 1, 2023
1bb8e50
remove backend specific methods
kevaundray Sep 1, 2023
3c44114
Merge remote-tracking branch 'origin/master' into kw/acvm-0-24
kevaundray Sep 3, 2023
179da4f
Merge remote-tracking branch 'origin/kw/acvm-0-24' into arv/assert_msgs
kevaundray Sep 3, 2023
f4b48ae
update to acvm 0.24.1
kevaundray Sep 3, 2023
b9a92a7
Merge remote-tracking branch 'origin/kw/acvm-0-24' into arv/assert_msgs
kevaundray Sep 3, 2023
6017201
Merge branch 'master' into arv/assert_msgs
sirasistant Sep 4, 2023
330fcde
Update crates/noirc_frontend/src/parser/errors.rs
sirasistant Sep 4, 2023
7540681
fix: improvements after peer review
sirasistant Sep 4, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/acvm_backend_barretenberg/src/bb/gates.rs
Original file line number Diff line number Diff line change
@@ -67,6 +67,6 @@ fn gate_command() {
};

let output = gate_command.run();
assert_eq!(output, 2775);
assert_eq!(output, 2788);
drop(temp_directory);
}