fix(ssa): codegen missing check for unary minus #2413
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #2412
Summary*
For normal binary expression we call
FunctionContext::insert_binary
which inserts a binary instruction and checks if truncation is needed.However, for unary minus we directly call into the
FunctionBuilder
which skips this check -- this PR replaces that function call with a call toFunctionContext::insert_binary
.The
location
argument inFunctionContext::insert_binary
is also made optional sinceast::Unary
doesn't have a location and it would be a bit of a pain to add it, because in mono we sometimes generate unary expressions on the fly.Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.