feat: Basic implementation of traits#2368

Merged

jfecher merged 31 commits intonoir-lang:masterfrom metacraft-labs:yordan/resolve_traits_initial

Aug 30, 2023

+984-15

Commits on Aug 29, 2023

Maybe it's better this way
ymadzhunkov
committed
Collect traits from AST to def_map
ymadzhunkov
committed
Collect trait implementations in def collector
ymadzhunkov
committed
Resolve traits
ymadzhunkov
committed
Separate collected trait implementations
ymadzhunkov
committed
fix(testsuite): converted traits tests to proper nargo packages

nickysn
authored and
ymadzhunkov
committed
fix(testsuite): added Prover.toml files to the traits compile_failure tests

nickysn
authored and
ymadzhunkov
committed
fix(testsuite): Move trait test into correct place so it can run automatically
ymadzhunkov
committed
Rename trait_not_exists -> trait_not_in_scope
ymadzhunkov
committed
Resolve some of PR comments
ymadzhunkov
committed
better naming as requsted in PR
ymadzhunkov
committed
Remove empty else and rename noir_function -> impl_method
ymadzhunkov
committed
Check for matching of trait implementation method, when unspecified return type
ymadzhunkov
committed
Apply cargo clippy suggestions
ymadzhunkov
committed
Delete duplicated test
ymadzhunkov
committed
Partial trait resolution
ymadzhunkov
committed
Extract comparison of return type into stuct assosiated method
ymadzhunkov
committed
Add test of a trait with default implemetation that is used
ymadzhunkov
committed
Allow usage of default trait implementation
ymadzhunkov
committed
RP remark: fix typo
ymadzhunkov
committed
Maybem it's better this way
ymadzhunkov
committed
Fix clippy warnings
ymadzhunkov
committed
Add test of override ot Trait default method
ymadzhunkov
committed
Try to fix 'nix flake check -L'
ymadzhunkov
committed
Try to fix CI dependency failed build
ymadzhunkov
committed
An other try
ymadzhunkov
committed
Update crates/noirc_frontend/src/ast/mod.rs

authored and
ymadzhunkov
committed
Update crates/noirc_frontend/src/hir/def_collector/dc_crate.rs

authored and
ymadzhunkov
committed
Build fix and cargo fmt
ymadzhunkov
committed
Fix build after rebase of master
ymadzhunkov
committed
Fix trait tests
ymadzhunkov
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Basic implementation of traits#2368

Commits on Aug 29, 2023

Maybe it's better this way

Collect traits from AST to def_map

Collect trait implementations in def collector

Resolve traits

Separate collected trait implementations

fix(testsuite): converted traits tests to proper nargo packages

fix(testsuite): added Prover.toml files to the traits compile_failure tests

fix(testsuite): Move trait test into correct place so it can run automatically

Rename trait_not_exists -> trait_not_in_scope

Resolve some of PR comments

better naming as requsted in PR

Remove empty else and rename noir_function -> impl_method

Check for matching of trait implementation method, when unspecified return type

Apply cargo clippy suggestions

Delete duplicated test

Partial trait resolution

Extract comparison of return type into stuct assosiated method

Add test of a trait with default implemetation that is used

Allow usage of default trait implementation

RP remark: fix typo

Maybem it's better this way

Fix clippy warnings

Add test of override ot Trait default method

Try to fix 'nix flake check -L'

Try to fix CI dependency failed build

An other try

Update crates/noirc_frontend/src/ast/mod.rs

Update crates/noirc_frontend/src/hir/def_collector/dc_crate.rs

Build fix and cargo fmt

Fix build after rebase of master

Fix trait tests