Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Location stack #2306

Closed
wants to merge 5 commits into from
Closed

chore: Location stack #2306

wants to merge 5 commits into from

Conversation

Ethan-000
Copy link
Contributor

Description

Problem*

#2214

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@Ethan-000 Ethan-000 marked this pull request as draft August 14, 2023 15:29
@Ethan-000
Copy link
Contributor Author

before i do anything further, @jfecher is this something that you were thinking of

my understanding is that you want a vector of locations associated with each instruction and when reporting errors. poping each location in sequence until the final one which report with the actual location

this means that when inlining. with each recursive call, incline_block() in inline_function() has to also pass in the location information of the function to the instructions inside the function

feel free to give any comments

@jfecher
Copy link
Contributor

jfecher commented Aug 14, 2023

Looks like there was some repeated work done unfortunately. I just put up another PR here: #2310 with some changes I was working on. It's currently displaying errors with the full call stack but each call is rendered as a separate error. I'd like to fixup the error format a bit before marking it ready for review but otherwise it is complete.

@jfecher jfecher closed this Aug 14, 2023
@kevaundray kevaundray deleted the e/location branch August 14, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants