feat: Include full module path to structs in abi #2296
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the work from #2266 and prepends the full module path to struct type names in the ABI. The name is composed as
package_name::module_1::...::module_N::struct_name
.For example:
Note that the
crate_name
added toCrateData
is optional, since some instantiations of crates seem to be coming from not-a-package. Also, I was unsure as to emit the name of the package or the name of the dependency as registered in the contract package TOML. I decided to go with the former, since this ABI may be consumed from a location that doesn't know the mapping from dependency names to packages.Now, if this feels like we're spreading too much data across internal types, I'm fine closing this PR and looking for an alternate solution.
Fixes #2238