Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow returning nested arrays from brillig #2047

Merged
merged 6 commits into from
Jul 26, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
docs: added doc comment
sirasistant committed Jul 26, 2023
commit 05554c7ba5b249af24ea9b2c76cbc7ae8b1ab24e
Original file line number Diff line number Diff line change
@@ -897,6 +897,8 @@ impl AcirContext {
}
}

sirasistant marked this conversation as resolved.
Show resolved Hide resolved
/// Recursively create acir values for returned arrays. This is necessary because a brillig returned array can have nested arrays as elements.
/// A singular array of witnesses is collected for a top level array, by deflattening the assigned witnesses at each level.
fn brillig_array_output(
&mut self,
element_types: &[AcirType],