Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add the ability to specify a default member #1926

Merged
merged 5 commits into from Jul 14, 2023
Merged

chore: add the ability to specify a default member #1926

merged 5 commits into from Jul 14, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 13, 2023 •
edited by ghost
Loading

Description

add the ability to specify a default member

Problem

step towards #794

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@ghost ghost marked this pull request as ready for review July 13, 2023 17:37
@ghost ghost requested a review from kevaundray July 13, 2023 19:22
kevaundray
kevaundray previously approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- good point about using PathBuf

@ghost ghost requested a review from kevaundray July 14, 2023 11:06
@kevaundray kevaundray enabled auto-merge July 14, 2023 13:05
@kevaundray kevaundray added this pull request to the merge queue Jul 14, 2023
Merged via the queue into noir-lang:master with commit 1056ba1 Jul 14, 2023
@ghost ghost deleted the default-member branch July 14, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kevaundray