-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: implement basic workspace file functionality #1913
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
reviewed
Jul 12, 2023
ghost
marked this pull request as ready for review
July 12, 2023 17:17
kevaundray
reviewed
Jul 12, 2023
kevaundray
reviewed
Jul 12, 2023
ghost
requested a review
from kevaundray
July 12, 2023 21:20
I don't think we want a package manifest and a workspace manifest represented by the same struct. these two things are separate in my mind. |
kevaundray
reviewed
Jul 13, 2023
kevaundray
reviewed
Jul 13, 2023
kevaundray
reviewed
Jul 13, 2023
kevaundray
reviewed
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, left some comments
ghost
requested a review
from kevaundray
July 13, 2023 12:19
kevaundray
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implement basic workspace file functionality
Problem
step towards #794
Summary
PR Checklist
cargo fmt
on default settings.