Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implement basic workspace file functionality #1913

Merged
merged 9 commits into from Jul 13, 2023
Merged

chore: implement basic workspace file functionality #1913

merged 9 commits into from Jul 13, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 12, 2023

Description

implement basic workspace file functionality

Problem

step towards #794

Summary

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@ghost ghost marked this pull request as ready for review July 12, 2023 17:17
@ghost ghost requested a review from kevaundray July 12, 2023 21:20
@TomAFrench
Copy link
Member

I don't think we want a package manifest and a workspace manifest represented by the same struct. these two things are separate in my mind.

Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, left some comments

@ghost ghost requested a review from kevaundray July 13, 2023 12:19
@kevaundray kevaundray enabled auto-merge July 13, 2023 12:40
@kevaundray kevaundray added this pull request to the merge queue Jul 13, 2023
Merged via the queue into noir-lang:master with commit 4969da7 Jul 13, 2023
@ghost ghost deleted the basic-workspace branch July 13, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants