Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ssa refactor): Add support for the distinct keyword #1810

Merged
merged 4 commits into from
Jun 23, 2023

Conversation

kevaundray
Copy link
Contributor

Description

Related to #1796

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray marked this pull request as ready for review June 23, 2023 15:46
Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Bigger picture as I said in the issue, not sure about distinct keyword. To me this indicates some other feature like a lack of aliasing, I guess it's similar. But once we are more sophisticated about Noir calling conventions we can revisit it, as I don't have use cases in mind a better solution could also address.

@kevaundray kevaundray added this pull request to the merge queue Jun 23, 2023
Merged via the queue into master with commit a365464 Jun 23, 2023
@kevaundray kevaundray deleted the kw/add-distinct branch June 23, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants