Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssa refactor): Translate strings as arrays of characters #1669

Merged
merged 1 commit into from
Jun 13, 2023
Merged

fix(ssa refactor): Translate strings as arrays of characters #1669

merged 1 commit into from
Jun 13, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Jun 13, 2023

Description

Problem*

Resolves #1665

Summary*

This PR sets out to

Example

Before:

After:

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher requested a review from joss-aztec June 13, 2023 16:00
@kevaundray kevaundray added this pull request to the merge queue Jun 13, 2023
Merged via the queue into master with commit 2ba2ef6 Jun 13, 2023
@kevaundray kevaundray deleted the jf/fix-1665 branch June 13, 2023 18:22
This was referenced Jun 13, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

@joss-aztec joss-aztec Awaiting requested review from joss-aztec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSA gen interprets strings as references
2 participants
@jfecher @kevaundray