fix(ssa refactor): Const folding array handling #1640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
reviewed
Jun 12, 2023
| /// and it isn't already in the cache, it will be recursively resolved and added to the cache. | ||
| /// This is necessary because processing instruction results alone is not sufficient for | ||
| /// catching all arrays that have been affected by the pass. | ||
| fn resolve_value(&mut self, function: &mut Function, value: ValueId) -> ValueId { |
There was a problem hiding this comment.
Can this function can be removed if we use .set_value_from_id on any updated results?
It seems either way that this fix would need to apply to every pass that changes ValueIds.
5 tasks
|
Closing in favour of #1674 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves GH-1618
Summary*
Arrays for which the underlying elements had changed were not being updated as part of the constant folding pass.
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.