Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ssa refactor): acir-gen for NOT instruction #1450

Merged
merged 29 commits into from
May 31, 2023
Merged

Conversation

joss-aztec
Copy link
Contributor

Description

Problem*

Resolves

Summary*

Add ACIR gen for the not instruction

This PR sets out to

Example

fn main(x : bool) -> pub bool {
    !x
}

compiles to:

current witness index : 3
public parameters indices : []
return value indices : [2]
BLACKBOX::RANGE [(_1, num_bits: 1)] [ ]
EXPR [ (-1, _1) (-1, _2) 1 ]

This PR is dependent on #1449 for capturing bool bit widths in parameters to main

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@joss-aztec joss-aztec requested a review from kevaundray May 30, 2023 17:45
@kevaundray kevaundray changed the title chore(ssa refactor): acir-gen for ! instruction chore(ssa refactor): acir-gen for NOT instruction May 30, 2023
Base automatically changed from kw/add-comparison to master May 30, 2023 19:15
@kevaundray kevaundray enabled auto-merge May 31, 2023 18:08
@kevaundray kevaundray added this pull request to the merge queue May 31, 2023
Merged via the queue into master with commit 9c05a24 May 31, 2023
@kevaundray kevaundray deleted the joss/not-op branch May 31, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants