feat(nargo)!: retire print-acir in favour of flag #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
joss-aztec
changed the title
kevaundray
previously approved these changes
May 9, 2023
There was a problem hiding this comment.
-
We can open up another issue to have --show-ssa only show the SSA IR. If a user wants to see both they can just pass in
--show-ssa --print-acir -
And also another issue to canonicalize the word used for printing to stdout, we use
printandshowcurrently. I think emit is a common one, ieemit-asm
TomAFrench
added a commit
that referenced
this pull request
May 17, 2023
* master: (66 commits) feat(nargo)!: retire print-acir in favour of flag (#1328) chore(ssa): enable cse for assert (#1350) chore(ssa refactor): Add basic instruction simplification (#1329) chore(noir): Release 0.6.0 (#1279) feat: enable to_radix for any field element (#1343) chore(ssa refactor): Simplify inlining pass and fix inlining failure (#1337) chore!: Update to acvm 0.11.0 (#1322) feat: Add ECDSA secp256k1 builtin test (#1294) chore: add support for encoding/decoding inputs from JSON (#1325) feat: Issue an error when attempting to use a `return` expression (#1330) chore(ssa refactor): Fix inlining bug (#1335) fix: to-bits and to-radix for > 128 bits (#1312) chore(parser): Parser error optimisation (#1292) chore(ssa refactor): Implement function inlining (#1293) chore: fix installation link in readme (#1326) chore: fix installation link in readme (#1326) feat(stdlib): Add keccak (#1249) fix: Parsing nested generics (#1319) chore(ssa refactor): Document some SSA-gen functions (#1321) fix: Assigning to tuple fields (#1318) ...
TomAFrench
added a commit
that referenced
this pull request
May 18, 2023
* master: fix: Fix modulo operator for comptime values (#1361) chore: clarify that `verify_signature` takes a hashed message (#1365) feat: pass in closure to `Driver` to signal backend opcode support (#1349) feat(nargo)!: retire print-acir in favour of flag (#1328) chore(ssa): enable cse for assert (#1350) chore(ssa refactor): Add basic instruction simplification (#1329) chore(noir): Release 0.6.0 (#1279)
TomAFrench
added a commit
that referenced
this pull request
May 18, 2023
* master: fix: Fix modulo operator for comptime values (#1361) chore: clarify that `verify_signature` takes a hashed message (#1365) feat: pass in closure to `Driver` to signal backend opcode support (#1349) feat(nargo)!: retire print-acir in favour of flag (#1328) chore(ssa): enable cse for assert (#1350) chore(ssa refactor): Add basic instruction simplification (#1329) chore(noir): Release 0.6.0 (#1279)
TomAFrench
added a commit
that referenced
this pull request
May 18, 2023
* master: fix: Fix modulo operator for comptime values (#1361) chore: clarify that `verify_signature` takes a hashed message (#1365) feat: pass in closure to `Driver` to signal backend opcode support (#1349) feat(nargo)!: retire print-acir in favour of flag (#1328) chore(ssa): enable cse for assert (#1350) chore(ssa refactor): Add basic instruction simplification (#1329) chore(noir): Release 0.6.0 (#1279)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #6
Description
Summary of changes
Retire
nargo print-acirin favour ofnargo compile --print-acir <program name>. Arguably this feature is redundant because the--show-ssaflag also outputs the compiled ACIR. However, I'd keep both because--show-ssawill be used by those debugging the compiler (who want a full trace), and not by those wishing to reason about their resultant program only.Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
That printing of acir is now instead invoked via a flag
Additional context