Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ECDSA secp256k1 builtin test #1294

Merged
merged 20 commits into from
May 12, 2023
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/nargo_cli/tests/prove_and_verify.rs
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ mod tests {
test_dir.file_name().into_string().expect("Directory can't be converted to string");
let test_program_dir = &test_dir.path();

if test_name != "ecdsa_secp256k1" {
kevaundray marked this conversation as resolved.
Show resolved Hide resolved
continue;
}
if config_data["exclude"].contains(&test_name) {
println!("Skipping test {test_name}");
continue;
Expand Down
6 changes: 6 additions & 0 deletions crates/nargo_cli/tests/test_data/ecdsa_secp256k1/Nargo.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[package]
name = "ECDSA secp256k1 verification"
authors = [""]
compiler_version = "0.1"

[dependencies]
209 changes: 209 additions & 0 deletions crates/nargo_cli/tests/test_data/ecdsa_secp256k1/Prover.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,209 @@

hashed_message = [
0x3a,
0x73,
0xf4,
0x12,
0x3a,
0x5c,
0xd2,
0x12,
0x1f,
0x21,
0xcd,
0x7e,
0x8d,
0x35,
0x88,
0x35,
0x47,
0x69,
0x49,
0xd0,
0x35,
0xd9,
0xc2,
0xda,
0x68,
0x06,
0xb4,
0x63,
0x3a,
0xc8,
0xc1,
0xe2,
]
message = [
0x49,
0x6e,
0x73,
0x74,
0x72,
0x75,
0x63,
0x74,
0x69,
0x6f,
0x6e,
0x73,
0x20,
0x75,
0x6e,
0x63,
0x6c,
0x65,
0x61,
0x72,
0x2c,
0x20,
0x61,
0x73,
0x6b,
0x20,
0x61,
0x67,
0x61,
0x69,
0x6e,
0x20,
0x6c,
0x61,
0x74,
0x65,
0x72,
0x2e,
]
pub_key_x = [
0xa0,
0x43,
0x4d,
0x9e,
0x47,
0xf3,
0xc8,
0x62,
0x35,
0x47,
0x7c,
0x7b,
0x1a,
0xe6,
0xae,
0x5d,
0x34,
0x42,
0xd4,
0x9b,
0x19,
0x43,
0xc2,
0xb7,
0x52,
0xa6,
0x8e,
0x2a,
0x47,
0xe2,
0x47,
0xc7,
]
pub_key_y = [
0x89,
0x3a,
0xba,
0x42,
0x54,
0x19,
0xbc,
0x27,
0xa3,
0xb6,
0xc7,
0xe6,
0x93,
0xa2,
0x4c,
0x69,
0x6f,
0x79,
0x4c,
0x2e,
0xd8,
0x77,
0xa1,
0x59,
0x3c,
0xbe,
0xe5,
0x3b,
0x03,
0x73,
0x68,
0xd7,
]
signature = [
0xe5,
0x08,
0x1c,
0x80,
0xab,
0x42,
0x7d,
0xc3,
0x70,
0x34,
0x6f,
0x4a,
0x0e,
0x31,
0xaa,
0x2b,
0xad,
0x8d,
0x97,
0x98,
0xc3,
0x80,
0x61,
0xdb,
0x9a,
0xe5,
0x5a,
0x4e,
0x8d,
0xf4,
0x54,
0xfd,
0x28,
0x11,
0x98,
0x94,
0x34,
0x4e,
0x71,
0xb7,
0x87,
0x70,
0xcc,
0x93,
0x1d,
0x61,
0xf4,
0x80,
0xec,
0xbb,
0x0b,
0x89,
0xd6,
0xeb,
0x69,
0x69,
0x01,
0x61,
0xe4,
0x9a,
0x71,
0x5f,
0xcd,
0x55,
]
27 changes: 27 additions & 0 deletions crates/nargo_cli/tests/test_data/ecdsa_secp256k1/src/main.nr
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
use dep::std;

// This is not fully supported by any backend
// Barretenberg backend will not verify a proof, even though it
// is below the WASM limit.
//
// This is here for two reasons:
// - To check for API regressions.
// - Noir should be agnostic to backends, so even though
// the only backend implemented does not work properly for this,
// we can still implement it on the frontend.
fn main(message : [u8;38],hashed_message : [u8;32], pub_key_x : [u8;32], pub_key_y : [u8;32], signature : [u8;64]) {
// Is there ever a situation where someone would want
// to ensure that a signature was invalid?
let expected= std::hash::sha256(message);
kevaundray marked this conversation as resolved.
Show resolved Hide resolved
assert(hashed_message == expected);

let x = std::ecdsa_secp256k1::verify_signature(pub_key_x, pub_key_y, signature, hashed_message);
kevaundray marked this conversation as resolved.
Show resolved Hide resolved
assert(x == 1);
}

// TODO: The following will fail in ssa:
//
//
//fn main(message : [u8;38],hashed_message : [u8;32], _pub_key_x : [u8;32], _pub_key_y : [u8;32], _signature : [u8;64]) {
kevaundray marked this conversation as resolved.
Show resolved Hide resolved
// assert(hashed_message == std::hash::sha256(message));
//}
6 changes: 3 additions & 3 deletions flake.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.