Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Labeling doc needed PRs with uppercase checkbox - [X] #1290

Merged
merged 1 commit into from
May 4, 2023

Conversation

Savio-Sou
Copy link
Collaborator

@Savio-Sou Savio-Sou commented May 4, 2023

Description

The doc needed labeling CI was able to detect - [x] but not - [X] documentation checkbox on PRs. (See #1271 as an example.)

This PR fixes the labeling CI to label a PR when either a - [x] or - [X] documentation checkbox is detected.

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

PR in testing repo for reference: noir-lang-test#9

BEGIN_COMMIT_OVERRIDE
chore(ci): allow labeling doc needed PRs with uppercase X
END_COMMIT_OVERRIDE

@kevaundray kevaundray added this pull request to the merge queue May 4, 2023
Merged via the queue into master with commit 16fd327 May 4, 2023
@kevaundray kevaundray deleted the labeler-uppercase-X branch May 4, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants