Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssa refactor): Implement dominator tree #1278

Merged
merged 12 commits into from
May 3, 2023
Merged

feat(ssa refactor): Implement dominator tree #1278

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e5347d3
feat(ssa refactor): dominator tree
joss-aztec Apr 28, 2023
765ba8f
reorder functions
joss-aztec Apr 28, 2023
898bca1
chore(ssa refactor): use true post order
joss-aztec Apr 28, 2023
56331ba
chore(ssa refactor): externalise PostOrder
joss-aztec Apr 28, 2023
2eb5e54
chore(ssa refactor): use FunctionBuilder in tests
joss-aztec Apr 28, 2023
98bfaeb
chore(ssa refactor): add header comments
joss-aztec Apr 28, 2023
303c828
chore(ssa refactor): clippy
joss-aztec Apr 28, 2023
3159c6b
chore(ssa refactor): elaborate header comments
joss-aztec Apr 28, 2023
3c362a4
chore(ssa refactor): domtree/post-order cleanup:
joss-aztec May 2, 2023
849cdf3
chore(ssa refactor): use domtree helper in tests
joss-aztec May 2, 2023
f8422ef
fix: update usage of cfg.pred_iter to cfg.predecessors
joss-aztec May 2, 2023
24e7913
chore(saa refactor): tidy up test and naming
joss-aztec May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/noirc_evaluator/src/ssa_refactor/ir.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ pub(crate) mod basic_block;
pub(crate) mod cfg;
pub(crate) mod constant;
pub(crate) mod dfg;
pub(crate) mod dom;
pub(crate) mod function;
pub(crate) mod instruction;
pub(crate) mod map;
pub(crate) mod post_order;
pub(crate) mod printer;
pub(crate) mod types;
pub(crate) mod value;
4 changes: 3 additions & 1 deletion crates/noirc_evaluator/src/ssa_refactor/ir/basic_block.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ impl BasicBlock {
/// Iterate over all the successors of the currently block, as determined by
/// the blocks jumped to in the terminator instruction. If there is no terminator
/// instruction yet, this will iterate 0 times.
pub(crate) fn successors(&self) -> impl ExactSizeIterator<Item = BasicBlockId> {
pub(crate) fn successors(
&self,
) -> impl ExactSizeIterator<Item = BasicBlockId> + DoubleEndedIterator {
match &self.terminator {
Some(TerminatorInstruction::Jmp { destination, .. }) => vec![*destination].into_iter(),
Some(TerminatorInstruction::JmpIf { then_destination, else_destination, .. }) => {
Expand Down
Loading