Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move backends to nargo_cli crate #1091

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Followup to #1085 (comment)

Description

Summary of changes

This PR moves all logic related to selection of proving backends from nargo to nargo_cli. This is necessary as we'll be wanting to build multiple crates within the workspace with different backends which all use nargo so this must be generic (as otherwise it will have mutually exclusive feature flags set).

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@TomAFrench TomAFrench added this pull request to the merge queue Apr 4, 2023
Merged via the queue into master with commit 0516e4a Apr 4, 2023
@TomAFrench TomAFrench deleted the move-backend-to-cli branch April 4, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants