feat(nargo): allow running nargo from any directory in package
#1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
force-pushed
the
search-parents-for-manifest
branch
from
b75ba67 to
64efa2d
Compare
kevaundray
previously approved these changes
Mar 20, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
* master: feat(nargo): add `InvalidPackageError` and `DependencyResolutionError` error types. (#1007)
kevaundray
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Baby step towards #794
Description
Summary of changes
Currently
nargocannot run except in the root directory of a noir package. This is a little annoying if you're in thesrcdirectory of a package butnargoisn't smart enough to compile the program inside it.When running the
nargoCLI we now search all ancestor directories for aNargo.tomlfile and then run in the context of that directory.Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context