-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using u16
for array sizes
#6245
Labels
enhancement
New feature or request
Comments
I don't see why we'd want to support u16 for array sizes as well. It seems like additional complexity for little to no gain |
Pinging @TomAFrench for the original motivation |
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 9, 2024
# Description ## Problem\* * Need to check that type constants fit into their `Kind`'s * The sizes of results from `op.function` and `evaluate_to_u32` are unchecked ## Summary\* Split out from #6094 - Some parts only work with its additional kind information - Several follow up issues, including: * #6247 * #6245 * #6238 ## Additional Context TODO: - [x] Add this test and/or similar execution tests unless we already have a similar one (sanity-check that global `Field` arithmetic works past `u32::MAX`) ```noir // 2^32 + 1 global A: Field = 4294967297; global B: Field = 4294967297; global C: Field = A + B; fn main() { // 2 * (2^32 + 1) assert(C == 8589934594); let mut leading_zeroes = 0; let mut stop = false; let bits: [u1; 64] = C.to_be_bits(); for i in 0..64 { if (bits[i] == 0) & !stop { leading_zeroes += 1; } else { stop = true; } } let size = 64 - leading_zeroes; // 8589934594 has 34 bits assert(size == 34); } ``` ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings. --------- Co-authored-by: Tom French <[email protected]> Co-authored-by: Maxim Vezenov <[email protected]> Co-authored-by: jfecher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
It's currently impossible to use
u16
for array sizes, but it would be useful for many arrays (u16::MAX == 65535
)Happy Case
Support
u16
as an array size (as above)Workaround
Yes
Workaround Description
A
u16
cast to au32
can be used as the array size, but there's a performance impactAdditional Context
No response
Project Impact
Nice-to-have
Blocker Context
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response
The text was updated successfully, but these errors were encountered: