Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the noirc_frontend::macros_api submodule #6176

Closed
TomAFrench opened this issue Sep 30, 2024 · 0 comments · Fixed by #6190
Closed

Remove the noirc_frontend::macros_api submodule #6176

TomAFrench opened this issue Sep 30, 2024 · 0 comments · Fixed by #6190
Assignees
@aakoshh
Labels
good first issue Good for newcomers

Comments

@TomAFrench
Copy link
Member

This submodule was intended to provide an API for MacroProcessors to hook into noirc_frontend. After #6087 we no long support MacroProcessors so we can remove this submodule.

This is fairly trivial but it seems like vscode as autoimported entries from here in various places elsewhere in the codebase so we'll need to update those imports to match which is a bit of legwork.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 30, 2024
@TomAFrench TomAFrench mentioned this issue Sep 30, 2024
Merged
5 tasks
@TomAFrench TomAFrench added the good first issue Good for newcomers label Sep 30, 2024
@aakoshh aakoshh mentioned this issue Oct 1, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 1, 2024
@aakoshh
chore: Remove macros_api module (#6190)
7077b01 
# Description

## Problem

Resolves #6176 

## Summary

Removes the `noir_frontend::macros_api` module and fixes the `use`
statements where it appeared.


## Additional Context

See the linked ticket for why it's not needed any more.

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aakoshh aakoshh

Labels
good first issue Good for newcomers
Projects
Noir
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Remove macros_api module noir-lang/noir
2 participants
@aakoshh @TomAFrench