Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown metaprogramming function panics #5539

Closed
michaeljklein opened this issue Jul 17, 2024 · 0 comments · Fixed by #5537
Closed

Unknown metaprogramming function panics #5539

michaeljklein opened this issue Jul 17, 2024 · 0 comments · Fixed by #5537
Labels
bug Something isn't working

Comments

@michaeljklein
Copy link
Contributor

Aim

Attempted to compile a program with an unknown metaprogramming function

pub fn main() { 
    foo!();
}

Expected Behavior

A user error to be returned

Bug

❯ nargo compile
The application panicked (crashed).
Message:  index out of bounds: the len is 3524 but the index is 18446744073709551615
Location: compiler/noirc_frontend/src/node_interner.rs:1039

To Reproduce

Project Impact

Nice-to-have

Impact Context

No response

Workaround

Yes

Workaround Description

Bisect the program to locate the unknown identifier

Additional Context

No response

Installation Method

Binary (noirup default)

Nargo Version

nargo version = 0.31.0 noirc version = 0.31.0+45e82a672b9ba7f7326e8d9f8800e2489013e2e8 (git version hash: 45e82a6, is dirty: false)

NoirJS Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@michaeljklein michaeljklein added the bug Something isn't working label Jul 17, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 17, 2024
@jfecher jfecher mentioned this issue Jul 17, 2024
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 18, 2024
vezenovm pushed a commit that referenced this issue Jul 18, 2024
@jfecher
fix: Don't panic when a macro fails to resolve (#5537)
6109ddc 
# Description

## Problem\*

Resolves #5539

## Summary\*

Use `try_definition` instead of `definition` in case there is an error
when resolving a macro.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Noir
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Don't panic when a macro fails to resolve noir-lang/noir
1 participant
@michaeljklein