Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICE when using a comptime let variable in runtime code #5388

Closed
Tracked by #4594
jfecher opened this issue Jul 2, 2024 · 0 comments · Fixed by #5391
Closed
Tracked by #4594

ICE when using a comptime let variable in runtime code #5388

jfecher opened this issue Jul 2, 2024 · 0 comments · Fixed by #5391
Assignees
@jfecher
Labels
bug Something isn't working

Comments

@jfecher
Copy link
Contributor

jfecher commented Jul 2, 2024

Aim

fn main() {
    comptime let x = 2;
    println(x);
}

Expected Behavior

2 to be printed

Bug

error: ICE: Variable not found during monomorphization
  ┌─ /.../src/main.nr:3:13
  │
3 │     println(x);
  │             -
  │
  = Call stack:
    1. /.../src/main.nr:3:13

To Reproduce

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Installation Method

None

Nargo Version

No response

NoirJS Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@jfecher jfecher added the bug Something isn't working label Jul 2, 2024
@jfecher jfecher self-assigned this Jul 2, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 2, 2024
This was referenced Jul 2, 2024
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 3, 2024
@jfecher
fix: ICE when using a comptime let variable in runtime code (#5391)
9fb7e4d 
# Description

## Problem\*

Resolves #5388

## Summary\*

We were getting an ICE error because all comptime blocks are removed,
but comptime let variables were not inlined at call sites. So given the
program

```rs
fn main() {
    comptime let x = 2;
    assert_eq(x, 2);
}
```
The monomorphizer would see:

```rs
fn main() {
    assert_eq(x, 2);
}
```

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfecher jfecher

Labels
bug Something isn't working
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ICE when using a comptime let variable in runtime code noir-lang/noir
1 participant
@jfecher