Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SchnorrVerify in Noir #4929

Closed
TomAFrench opened this issue Apr 26, 2024 · 0 comments
Closed

Implement SchnorrVerify in Noir #4929

TomAFrench opened this issue Apr 26, 2024 · 0 comments

Comments

@TomAFrench
Copy link
Member

Currently the only primitive we're missing to perform schnorr signature verification in Noir is variable base scalar multiplication.

https://github.com/AztecProtocol/aztec-packages/blob/82b17c8f0e9207db803fd3b824e63bac25ea69f6/barretenberg/cpp/src/barretenberg/stdlib/encryption/schnorr/schnorr.cpp#L41-L61

This is being added in AztecProtocol/aztec-packages#6039 at which point we'll be able to replace the SchnorrVerify opcode with an implementation in Noir.

Note that this could end up being less efficient without #4928 but it would be good to demonstrate that it's possible.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Apr 26, 2024
github-merge-queue bot pushed a commit that referenced this issue Jun 6, 2024
# Description

## Problem\*

Resolves #5054 and #4929

## Summary\*
Schnorr signature verification in Noir, using the MSM blackbox.


## Additional Context
The code is added to the schnorr test case, and it has also an assert
version.
This should be moved to the stdlib once we have numeric generics.
Meanwhile you need to pass a message with 32 additional bytes so we can
create an 'hash_input' array of the proper size.


## Documentation\*

Check one:
- [X] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [X] I have tested the changes locally.
- [X] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant