Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array to slice coercion regression #4639

Closed
jfecher opened this issue Mar 26, 2024 · 0 comments · Fixed by #4640
Closed

Array to slice coercion regression #4639

jfecher opened this issue Mar 26, 2024 · 0 comments · Fixed by #4640
Labels
bug Something isn't working

Comments

@jfecher
Copy link
Contributor

jfecher commented Mar 26, 2024

Aim

Testing the code in #4395

Expected Behavior

The code to execute successfully - albeit slowly.

Bug

The compiler panics with

The application panicked (crashed).
Message:  assertion `left == right` failed
  left: 2
 right: 1
Location: compiler/noirc_evaluator/src/ssa/opt/inlining.rs:420

To Reproduce

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Installation Method

None

Nargo Version

No response

NoirJS Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@jfecher jfecher added the bug Something isn't working label Mar 26, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Mar 26, 2024
This was referenced Mar 26, 2024
Merged
Closed
github-merge-queue bot pushed a commit that referenced this issue Mar 26, 2024
@jfecher
fix: Slice coercions (#4640)
c0bae17 
# Description

## Problem\*

Resolves #4639 

## Summary\*

The array to slice coercion was broken - and it seemingly has always
been so. The coercion never actually called `replace_expr` to replace
the original expression with the `as_slice(original_expr)` coercion.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Mar 26, 2024
TomAFrench pushed a commit that referenced this issue Apr 3, 2024
@jfecher @TomAFrench
fix: Slice coercions (#4640)
a61ccb0 
# Description

## Problem\*

Resolves #4639 

## Summary\*

The array to slice coercion was broken - and it seemingly has always
been so. The coercion never actually called `replace_expr` to replace
the original expression with the `as_slice(original_expr)` coercion.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Slice coercions noir-lang/noir
1 participant
@jfecher