Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support restricted bit sizes in noir: just support 1, 8, 32, 64, field #4162

Closed
Tracked by #4033
sirasistant opened this issue Jan 25, 2024 · 5 comments · Fixed by #4235
Closed
Tracked by #4033

Support restricted bit sizes in noir: just support 1, 8, 32, 64, field #4162

sirasistant opened this issue Jan 25, 2024 · 5 comments · Fixed by #4235
Assignees
@sirasistant
Labels
enhancement New feature or request

Comments

@sirasistant
Copy link
Contributor

sirasistant commented Jan 25, 2024 •
edited by Savio-Sou
Loading

Align integers in Noir with common integer sizes in other programming languages to

  1. Ease understanding and education
  2. Minimize complexity of having to work across many different integer sizes from different dependencies / libraries
@sirasistant sirasistant mentioned this issue Jan 25, 2024
Closed
12 tasks
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 25, 2024
@sirasistant sirasistant self-assigned this Jan 25, 2024
@sirasistant sirasistant added enhancement New feature or request brillig Unconstrained functions / brillig IR and removed brillig Unconstrained functions / brillig IR labels Jan 25, 2024
@Savio-Sou
Copy link
Collaborator

Good to create a separate Issue for providing fallback methods to ease users' migrations.

@Savio-Sou Savio-Sou mentioned this issue Jan 26, 2024
Closed
@sirasistant sirasistant moved this from 📋 Backlog to 🤔 Grooming in Noir Feb 1, 2024
@sirasistant sirasistant moved this from 🤔 Grooming to 🏗 In progress in Noir Feb 1, 2024
@sirasistant sirasistant changed the title Support restricted bit sizes; just support 8,16,32, 64, 128, field Support restricted bit sizes; just support 1,8,32, 64, 128, field Feb 1, 2024
@sirasistant sirasistant changed the title Support restricted bit sizes; just support 1,8,32, 64, 128, field Support restricted bit sizes; just support 1, 8, 32, 64, 128, field Feb 1, 2024
@sirasistant sirasistant mentioned this issue Feb 2, 2024
Merged
5 tasks
@sirasistant sirasistant changed the title Support restricted bit sizes; just support 1, 8, 32, 64, 128, field Support restricted bit sizes in noir: just support 1, 8, 32, 64, field Feb 2, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 2, 2024
@sirasistant
feat: Add warnings for usage of restricted bit sizes (#4234)
0ffc38b 
# Description

## Problem\*

Breaking change warning for
[#4162](#4162)
## Summary\*



## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [x] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@Savio-Sou Savio-Sou moved this from 🏗 In progress to 🚧 Blocked in Noir Feb 9, 2024
@Savio-Sou
Copy link
Collaborator

To go in after the PR that warns users.

@sirasistant sirasistant mentioned this issue Feb 13, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Feb 13, 2024
@sirasistant @kevaundray
feat!: Restrict bit sizes (#4235)
1048f81 
# Description
Restricts allowed bit sizes for integer types to 1,8,32 and 64. 
## Problem\*

Resolves #4162

## Summary\*



## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [x] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: kevaundray <[email protected]>
@github-project-automation github-project-automation bot moved this from 🚧 Blocked to ✅ Done in Noir Feb 13, 2024
@smanilov
Copy link

What happened to u16? I cannot find a relevant issue which discusses why support for it is removed. It seems like a lot of example code referenced from https://github.com/noir-lang/awesome-noir is using it, e.g. https://github.com/michaelelliot/noir-sha1.

@Savio-Sou Savio-Sou mentioned this issue Apr 24, 2024
Closed
@smanilov
Copy link

Ah, thanks, I thought that I was missing some reason why there shouldn't be a u16. The linked issue clarifies it 👍

@Savio-Sou
Copy link
Collaborator

Great question, thank you for asking it 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirasistant sirasistant

Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: Restrict bit sizes noir-lang/noir
3 participants
@smanilov @sirasistant @Savio-Sou