Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs on libraries preluded #3965

Closed
Savio-Sou opened this issue Jan 5, 2024 · 1 comment · Fixed by #3981
Closed

Update docs on libraries preluded #3965

Savio-Sou opened this issue Jan 5, 2024 · 1 comment · Fixed by #3981
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
0.21

Comments

@Savio-Sou
Copy link
Collaborator

Problem

As of #3693, certain popularly used libraries are now preluded (i.e. imported by default), but our docs were not updated accordingly.

For example, the Vectors page still recommends manually importing the library:

image

Happy Case

Update instructions and examples of libraries that are preluded.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@Savio-Sou Savio-Sou added enhancement New feature or request documentation Improvements or additions to documentation labels Jan 5, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 5, 2024
@Savio-Sou Savio-Sou added this to the 0.21.0 milestone Jan 5, 2024
@Savio-Sou
Copy link
Collaborator Author

@f01dab1e would you like to take this up as a part of the original PR?

@Savio-Sou Savio-Sou assigned Savio-Sou and unassigned Savio-Sou Jan 5, 2024
@ghost ghost mentioned this issue Jan 8, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 8, 2024
chore(docs): remove unused qualifications (#3981)
56bf1bf 
# Description

## Problem

Resolves #3965 

Check one:
- [ ] No documentation needed.
- [x] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist

- [x] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Noir
Archived in project
Milestone
0.21
Development

Successfully merging a pull request may close this issue.

chore(docs): remove unused qualifications
1 participant
@Savio-Sou