Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): add goto definition for locals #3706

Closed
Tracked by #1574
kobyhallx opened this issue Dec 7, 2023 · 0 comments
Closed
Tracked by #1574

feat(lsp): add goto definition for locals #3706

kobyhallx opened this issue Dec 7, 2023 · 0 comments

Comments

@kobyhallx
Copy link
Contributor

kobyhallx commented Dec 7, 2023 •
edited
Loading

As a Noir Developer
I would like to use my editor goto definition on locally defined symbol
so that I can easily jump to it's definition without need to search through text file.
@kobyhallx kobyhallx mentioned this issue Dec 7, 2023
Closed
4 tasks
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Dec 7, 2023
@kobyhallx kobyhallx mentioned this issue Dec 7, 2023
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 8, 2023
@kobyhallx @jfecher
feat(lsp): add goto definition for locals (#3705)
9dd465c 
# Description

## Problem\*

Resolves 

feat(lsp): add goto definition for locals #3706

## Summary\*

LSP server now understands goto definition command issued by Client (ie.
vscode). In case of local symbol it will jump to it's definition.

## Additional Context


## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: jfecher <[email protected]>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Noir
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kobyhallx